-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pallet-revive] Add Ethereum JSON-RPC server #6147
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Definitively gonna fire up some of the examples to try it out
use subxt::config::{signed_extensions, Config, PolkadotConfig}; | ||
|
||
#[subxt::subxt( | ||
runtime_metadata_path = "kitchensink.scale", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will not work against Westend AssetHub
, right? So this seems like a non starter to be tied to a specific runtime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testing this now with zombienet,
I think it will complain that metadata are not compatible,
for now the workaround would be to put each supported chain metadata behind a feature flag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it will complain that metadata are not compatible,
For a reason. The pallet ids will not match and you will be dispatching garbage.
for now the workaround would be to put each supported chain metadata behind a feature flag
Yeah this is fine for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought subxt can also fetch the metadata so we don't have to vendor it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah but it will download at build time since it is used for codegen. Might be an alternative for westend which has a public URL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only sane way of using subxt is to use the dynamic API and create the calls at runtime:
https://docs.rs/subxt/latest/subxt/dynamic/index.html
Redo of #5953